Author serhiy.storchaka
Recipients Dhiraj_Mishra, martin.panter, mbussonn, python-dev, serhiy.storchaka, takluyver
Date 2016-05-14.20:59:47
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1463259588.47.0.834036486375.issue26039@psf.upfronthosting.co.za>
In-reply-to
Content
There are yet few issues.

1. Currently RuntimeError is widely used in zipfile. But in most cases ValueError would be more appropriate since it programming error (for example ValueError is raised when try to read or write to closed file). See issue24693, but this is backward incompatible change. For new exceptions we are free to use any exception type without breaking backward compatibility. It looks to me, that ValueError is more appropriate is these cases than RuntimeError. What do you think about this Thomas? Here is a patch that changes exceptions types.

2. ZipInfo.is_dir() is not documented and lacks a docstring.

3. It would be better to make force_zip64 a keyword-only parameter. This would allow to add new positional parameters without breaking compatibility.
History
Date User Action Args
2016-05-14 20:59:48serhiy.storchakasetrecipients: + serhiy.storchaka, python-dev, takluyver, martin.panter, mbussonn, Dhiraj_Mishra
2016-05-14 20:59:48serhiy.storchakasetmessageid: <1463259588.47.0.834036486375.issue26039@psf.upfronthosting.co.za>
2016-05-14 20:59:48serhiy.storchakalinkissue26039 messages
2016-05-14 20:59:48serhiy.storchakacreate