Author xdegaye
Recipients Alex.Willmer, Roman.Evstifeev, lemburg, xdegaye, yan12125
Date 2016-05-11.07:50:37
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1462953037.83.0.546778989444.issue26855@psf.upfronthosting.co.za>
In-reply-to
Content
IMHO returning an integer for the sdk field would be better. The patch could use shutil.which() to avoid subprocess calls when getprop is not available. It would be better to use a 'try/except ValueError' clause instead of isdigit(). The OSError and UnicodeDecodeError exceptions should not be masked, as well as ValueError if sdk cannot be parsed as an int.
History
Date User Action Args
2016-05-11 07:50:37xdegayesetrecipients: + xdegaye, lemburg, Roman.Evstifeev, Alex.Willmer, yan12125
2016-05-11 07:50:37xdegayesetmessageid: <1462953037.83.0.546778989444.issue26855@psf.upfronthosting.co.za>
2016-05-11 07:50:37xdegayelinkissue26855 messages
2016-05-11 07:50:37xdegayecreate