Message 265294 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	xdegaye
Recipients	Alex.Willmer, Roman.Evstifeev, lemburg, xdegaye, yan12125
Date	2016-05-11.07:50:37
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1462953037.83.0.546778989444.issue26855@psf.upfronthosting.co.za>
In-reply-to

Content
IMHO returning an integer for the sdk field would be better. The patch could use shutil.which() to avoid subprocess calls when getprop is not available. It would be better to use a 'try/except ValueError' clause instead of isdigit(). The OSError and UnicodeDecodeError exceptions should not be masked, as well as ValueError if sdk cannot be parsed as an int.

IMHO returning an integer for the sdk field would be better. The patch could use shutil.which() to avoid subprocess calls when getprop is not available. It would be better to use a 'try/except ValueError' clause instead of isdigit(). The OSError and UnicodeDecodeError exceptions should not be masked, as well as ValueError if sdk cannot be parsed as an int.

History
Date	User	Action	Args
2016-05-11 07:50:37	xdegaye	set	recipients: + xdegaye, lemburg, Roman.Evstifeev, Alex.Willmer, yan12125
2016-05-11 07:50:37	xdegaye	set	messageid: <1462953037.83.0.546778989444.issue26855@psf.upfronthosting.co.za>
2016-05-11 07:50:37	xdegaye	link	issue26855 messages
2016-05-11 07:50:37	xdegaye	create