Author dchest
Recipients Zooko.Wilcox-O'Hearn, alex, christian.heimes, dchest, dstufft, gregory.p.smith
Date 2016-05-08.19:08:32
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <>
> I have replaced verify() with compare_digest().

+    >>> compare_digesty(cookie, '0102030405060708090a0b0c0d0e0f00')

Typo here. Also, this doesn't look like it compares the digest. Maybe you can keep the verify() function, but make it use compare_digest() -- this looks more clear to me:

>>> def verify(cookie, sig):
...     good_sig = sign(cookie)
...     return compare_digest(goodsig, sig)

> Python requires a C89 compatible compiler and 32bit architecture. C89 doesn't mandate 64bit integers. As far as I remember there is (or was) one buildbot with a compiler, that doesn't have 64 ints on an old SPARC system. All major platforms have 64bit ints. I might modify the implementation when the patch has landed.

Oh, I see. Thanks!
Date User Action Args
2016-05-08 19:08:32dchestsetrecipients: + dchest, gregory.p.smith, christian.heimes, alex, dstufft, Zooko.Wilcox-O'Hearn
2016-05-08 19:08:32dchestsetmessageid: <>
2016-05-08 19:08:32dchestlinkissue26798 messages
2016-05-08 19:08:32dchestcreate