Author christian.heimes
Recipients Zooko.Wilcox-O'Hearn, alex, christian.heimes, dchest, dstufft, gregory.p.smith
Date 2016-05-08.18:04:21
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1462730663.22.0.54609877693.issue26798@psf.upfronthosting.co.za>
In-reply-to
Content
Thanks for your review, Dmitry.

I have replaced verify() with compare_digest().

Python requires a C89 compatible compiler and 32bit architecture. C89 doesn't mandate 64bit integers. As far as I remember there is (or was) one buildbot with a compiler, that doesn't have 64 ints on an old SPARC system. All major platforms have 64bit ints. I might modify the implementation when the patch has landed.

#self.assertIn(h.name, self.supported_hash_names)
I now check for guaranteed and eventually supported hashes.

SSE is enabled on X64_86. I forgot to remove the comments.


The test suite is missing tests for salt, personal and tree hashing. I have asked Zooko and JPA for vectors.
History
Date User Action Args
2016-05-08 18:04:37christian.heimessetrecipients: + christian.heimes, gregory.p.smith, alex, dstufft, Zooko.Wilcox-O'Hearn, dchest
2016-05-08 18:04:23christian.heimessetmessageid: <1462730663.22.0.54609877693.issue26798@psf.upfronthosting.co.za>
2016-05-08 18:04:23christian.heimeslinkissue26798 messages
2016-05-08 18:04:23christian.heimescreate