Author martin.panter
Recipients StyXman, christian.heimes, martin.panter, neologix, vstinner
Date 2016-05-08.10:24:55
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1462703096.17.0.74579253201.issue26826@psf.upfronthosting.co.za>
In-reply-to
Content
There’s still something funny about your patches: the last one has a bit of configure script at the end of the posixmodule.c diff.

One other thing I thought of: “in” is not a practical keyword argument name in Python, because it is a reserved word. Yes, sendfile(**{"in": ...}) is already there, but I think we should find some other name for copy_file_range() before it is too late. Some ideas:

copy_file_range(input, output, count, offset_in, offset_out, flags)  # Spell them out
copy_file_range(fd_in, fd_out, len, off_in, off_out, flags)  # Direct from man page
copy_file_range(src, dst, count, offset_src, offset_dst, flags)  # Like os.replace(), shutil.copyfile(), etc
copy_file_range(fsrc, fdst, count, offset_src, offset_dst, flags)  # Like shutil.copyfileobj()

My favourites are probably “input”, or “src”.
History
Date User Action Args
2016-05-08 10:24:56martin.pantersetrecipients: + martin.panter, vstinner, christian.heimes, StyXman, neologix
2016-05-08 10:24:56martin.pantersetmessageid: <1462703096.17.0.74579253201.issue26826@psf.upfronthosting.co.za>
2016-05-08 10:24:56martin.panterlinkissue26826 messages
2016-05-08 10:24:55martin.pantercreate