Message264357
Serhiy:
I left review comments on the patch too.
I agree to "tightening" of the input arg type in these urlparse functions.
Before we for the next version, I think, it will be helpful to enumerate the behavior for wrong arg types for these functions that you would like to see.
1. Invalid formats like {}, [], None could just be TypeError.
2. The mix of bytes and str should be deprecated and we could give the suggestion for the encouraged single type in the deprecation warning.
3. Any thing else w.r.t to special rules for various parts of url.
In general, if we are going with the deprecation cycle, we would as well go with deciding on what to allow and present it in a simple way. |
|
Date |
User |
Action |
Args |
2016-04-27 06:39:03 | orsenthil | set | recipients:
+ orsenthil, r.david.murray, martin.panter, serhiy.storchaka, ztane, demian.brecht, luiz.poleto |
2016-04-27 06:39:03 | orsenthil | set | messageid: <1461739143.58.0.255315785312.issue22234@psf.upfronthosting.co.za> |
2016-04-27 06:39:03 | orsenthil | link | issue22234 messages |
2016-04-27 06:39:03 | orsenthil | create | |
|