Message264350
This is probably harmless, but Modules/_csv.c has the following code:
Py_INCREF(&Dialect_Type);
if (PyModule_AddObject(module, "Dialect", (PyObject *)&Dialect_Type))
return NULL;
However, PyModule_AddObject returns only -1 and 0. It also doesn't decref Dialect_Type if it returns -1 so I guess more correct code should be:
Py_INCREF(&Dialect_Type);
if (PyModule_AddObject(module, "Dialect", (PyObject *)&Dialect_Type) == -1) {
Py_DECREF(&Dialect_Type);
return NULL;
}
The same pattern can be found in a few more modules. |
|
Date |
User |
Action |
Args |
2016-04-27 05:36:44 | berker.peksag | set | recipients:
+ berker.peksag |
2016-04-27 05:36:44 | berker.peksag | set | messageid: <1461735404.8.0.653639688918.issue26868@psf.upfronthosting.co.za> |
2016-04-27 05:36:44 | berker.peksag | link | issue26868 messages |
2016-04-27 05:36:44 | berker.peksag | create | |
|