Message26381
Logged In: YES
user_id=357491
For the deldict.py crasher, if you look at the traceback
there is no good place to do a check that tp_dict is sane
except in type_module() or PyDict_GetItem(). Now adding the
NULL check in type_module() will fix this specific problem,
but that seems like an ad-hoc patch.
Why don't we check for NULL in PyDict_GetItem() and return
NULL just like the PyDict_Check() test? I am sure the
answer is "performance", but this is not PyDict_GETITEM()and
thus already is not the performance-critical version anyway.
So why shouldn't we check for NULL there and possibly catch
other errors? |
|
Date |
User |
Action |
Args |
2007-08-23 14:34:48 | admin | link | issue1303614 messages |
2007-08-23 14:34:48 | admin | create | |
|