Author rhettinger
Recipients Demur Rumed, abarnert, benjamin.peterson, brett.cannon, georg.brandl, haypo, ncoghlan, rhettinger, serhiy.storchaka, yselivanov
Date 2016-03-30.10:13:26
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1459332806.63.0.951946814011.issue26647@psf.upfronthosting.co.za>
In-reply-to
Content
Demur, I think you're on the right track here.  It will nice to be rid of the HAVE_ARGUMENT tests and to not have to decode the arguments one-byte at a time.  Overall, the patch looks good (although it includes several small unrelated changes).  Besides the speed benefit, the code looks cleaner than before.

I was surprised to see that the peephole optimizer grew larger, but the handling of extended arguments is likely worth it even though it adds several new wordy chunks of code.

When it comes to benchmarks, expect a certain amount of noise (especially from those that use I/O or that exercise the C-API more than the pure python bytecode).
History
Date User Action Args
2016-03-30 10:13:26rhettingersetrecipients: + rhettinger, brett.cannon, georg.brandl, ncoghlan, haypo, benjamin.peterson, serhiy.storchaka, yselivanov, abarnert, Demur Rumed
2016-03-30 10:13:26rhettingersetmessageid: <1459332806.63.0.951946814011.issue26647@psf.upfronthosting.co.za>
2016-03-30 10:13:26rhettingerlinkissue26647 messages
2016-03-30 10:13:26rhettingercreate