Message 262473 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	vstinner
Recipients	emptysquare, pitrou, serhiy.storchaka, vstinner, xdegaye
Date	2016-03-26.00:10:45
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1458951045.55.0.768901770093.issue22898@psf.upfronthosting.co.za>
In-reply-to

Content
warn_5.patch: The patch cannot be reviewed on Rietveld :-( You must not use the git format for diff. warn_5.patch: "if (globals == NULL) { (...) return 0; }" It looks like filename is not initialized. I suggest to use: filename = f->f_code->co_filename; It looks like you have to add: if (PyUnicode_Check(filename)) *filename = NULL; To mimick the code below.

warn_5.patch: The patch cannot be reviewed on Rietveld :-( You must not use the git format for diff.

warn_5.patch: "if (globals == NULL) { (...) return 0; }"

It looks like filename is not initialized. I suggest to use:

   *filename = f->f_code->co_filename;

It looks like you have to add:

   if (PyUnicode_Check(*filename)) *filename = NULL;

To mimick the code below.

History
Date	User	Action	Args
2016-03-26 00:10:45	vstinner	set	recipients: + vstinner, pitrou, xdegaye, serhiy.storchaka, emptysquare
2016-03-26 00:10:45	vstinner	set	messageid: <1458951045.55.0.768901770093.issue22898@psf.upfronthosting.co.za>
2016-03-26 00:10:45	vstinner	link	issue22898 messages
2016-03-26 00:10:45	vstinner	create