➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author vstinner
Recipients Arfrever, akira, martin.panter, piotr.dobrogost, pitrou, serhiy.storchaka, vstinner
Date 2016-03-24.14:38:14
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1458830294.93.0.306432798425.issue19829@psf.upfronthosting.co.za>
In-reply-to
Content 
del-detach.patch: I don't understand the change in _pyio.py. I think that the change on socket.py is no more need since the change 46329eec5515 (issue #26590).

del-flush.patch:
* change on IOBase.__del__() change the behaviour compared to the io module, I don't think that it's correct. I may also break backward compatibility :-/
* change on fileio.c implements a finalizer for FileIO: io.IOBase already implements a finalizer which calls close(), I'm not sure that this change is needed?
* change on iobase.c removes io.IOBase finalizer. I don't understand this. It breaks ResourceWarning on io.Buffered* and io.TextIOWrapper classes, no?

Well, I guess that these two patches were written before Serhiy reimplemented the FileIO in pure Python, and this change outdated your two patches.
History
Date User Action Args
2016-03-24 14:38:14vstinnersetrecipients: + vstinner, pitrou, Arfrever, akira, martin.panter, piotr.dobrogost, serhiy.storchaka
2016-03-24 14:38:14vstinnersetmessageid: <1458830294.93.0.306432798425.issue19829@psf.upfronthosting.co.za>
2016-03-24 14:38:14vstinnerlinkissue19829 messages
2016-03-24 14:38:14vstinnercreate