Author xdegaye
Recipients Arfrever, Sjlver, WanderingLogic, brett.cannon, doko, koobs, loewis, martin.panter, pitrou, python-dev, xdegaye
Date 2016-03-15.19:49:20
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1458071361.05.0.803239408711.issue22359@psf.upfronthosting.co.za>
In-reply-to
Content
> But I am a bit worried at the new makefile syntax [ifeq directive and $(findstring) function]. I suspect it is Gnu specific, and that Python tries to support other versions of Make as well.

Yes, they are both GNU extensions :(

To avoid modifying configure.ac since the information is already available, the recipes could be modified with the following conditional:

    cross_compiling=$$(echo $(PYTHON_FOR_BUILD) | sed "s/.*_PYTHON_HOST_PLATFORM.*/yes/"); \
    if [ "$$cross_compiling" = "yes" ]; then \
          touch $@;
    else \
          # The original recipes.
    fi

So the built binaries $(PGEN) and Programs/_freeze_importlib would be dummy empty files, but that would not prevent Programs/_freeze_importlib.o, $(LIBRARY_OBJS_OMIT_FROZEN) and $(PGENOBJS) to be needlessly cross-compiled.
History
Date User Action Args
2016-03-15 19:49:21xdegayesetrecipients: + xdegaye, loewis, brett.cannon, doko, pitrou, Arfrever, python-dev, martin.panter, koobs, Sjlver, WanderingLogic
2016-03-15 19:49:21xdegayesetmessageid: <1458071361.05.0.803239408711.issue22359@psf.upfronthosting.co.za>
2016-03-15 19:49:21xdegayelinkissue22359 messages
2016-03-15 19:49:21xdegayecreate