Message261714
Hmm, I haven't looked closely, but some high level thoughts.
I'm worried about making mock too complex here. We already say folk should use a VFS for complex file based tests, and there's quite a chunk of code you're adding - perhaps better to just use a VFS?
I don't like mock importing mock_open and mock_open importing mock: please keep this in a single mock.py at this point. |
|
Date |
User |
Action |
Args |
2016-03-14 02:31:17 | rbcollins | set | recipients:
+ rbcollins, ezio.melotti, r.david.murray, michael.foord, Niv Ben-David |
2016-03-14 02:31:17 | rbcollins | set | messageid: <1457922677.87.0.437268428924.issue25690@psf.upfronthosting.co.za> |
2016-03-14 02:31:17 | rbcollins | link | issue25690 messages |
2016-03-14 02:31:17 | rbcollins | create | |
|