This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author rbcollins
Recipients Niv Ben-David, ezio.melotti, michael.foord, r.david.murray, rbcollins
Date 2016-03-14.02:31:17
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1457922677.87.0.437268428924.issue25690@psf.upfronthosting.co.za>
In-reply-to
Content
Hmm, I haven't looked closely, but some high level thoughts.

I'm worried about making mock too complex here. We already say folk should use a VFS for complex file based tests, and there's quite a chunk of code you're adding - perhaps better to just use a VFS?

I don't like mock importing mock_open and mock_open importing mock: please keep this in a single mock.py at this point.
History
Date User Action Args
2016-03-14 02:31:17rbcollinssetrecipients: + rbcollins, ezio.melotti, r.david.murray, michael.foord, Niv Ben-David
2016-03-14 02:31:17rbcollinssetmessageid: <1457922677.87.0.437268428924.issue25690@psf.upfronthosting.co.za>
2016-03-14 02:31:17rbcollinslinkissue25690 messages
2016-03-14 02:31:17rbcollinscreate