Author martin.panter
Recipients Alexander.Belopolsky, Anders.Hovmöller, Arfrever, aymeric.augustin, barry, belopolsky, berker.peksag, cvrebert, davydov, deronnax, eric.araujo, flying sheep, jcea, jstasiak, jwilk, karlcow, kirpit, martin.panter, mcepl, mihaic, nagle, pbryan, perey, piotr.dobrogost, r.david.murray, roysmith, vstinner
Date 2016-02-18.01:46:13
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1455759976.2.0.730480109745.issue15873@psf.upfronthosting.co.za>
In-reply-to
Content
Hi Aymeric Augustin. I am guessing you are the original author of the code and tests in Django for parsing datetime strings (https://bugs.python.org/issue15873#msg260342). If so, would you be happy for it to be incorporated into Python?

Mathieu: I left a couple quick review comments. (Normally I leave a message in the main bug thread, but I forgot the other time.)

Doc strings: Generally I think we keep the doc strings to a minimum, and leave the main documentation for the RST files. For the RST documentation, I would suggest including a rough summary of the format. E.g. for time.fromisoformat(), something like “The string should be in the RFC’s ‘full-time’ format, which looks like HH:MM:SS[.mmmmmm][Z|±HH:MM].”

Now that you added the two new regex strings, I can see that it might be useful to keep them together, rather than next to each class. Or you could even make them class attributes. No strong opinions either way; whatever works for you I think.
History
Date User Action Args
2016-02-18 01:46:17martin.pantersetrecipients: + martin.panter, barry, jcea, roysmith, belopolsky, nagle, vstinner, jwilk, mcepl, eric.araujo, Arfrever, r.david.murray, davydov, cvrebert, karlcow, Alexander.Belopolsky, perey, flying sheep, mihaic, aymeric.augustin, berker.peksag, piotr.dobrogost, kirpit, Anders.Hovmöller, jstasiak, deronnax, pbryan
2016-02-18 01:46:16martin.pantersetmessageid: <1455759976.2.0.730480109745.issue15873@psf.upfronthosting.co.za>
2016-02-18 01:46:16martin.panterlinkissue15873 messages
2016-02-18 01:46:13martin.pantercreate