Message260414
Looking over the code for communicate(), I think setting bufsize=0 should not cause a performance problem in the original use case. Communicate() either calls stdin.write() once, or bypasses the file object and calls os.write(). Only if stdin, stdout, etc were used before communicate(), then there could be a problem (and subtly different behaviour).
I left some suggestions on the code review. |
|
Date |
User |
Action |
Args |
2016-02-18 00:05:17 | martin.panter | set | recipients:
+ martin.panter, gvanrossum, vstinner, memeplex, yselivanov |
2016-02-18 00:05:17 | martin.panter | set | messageid: <1455753917.06.0.299630992022.issue26372@psf.upfronthosting.co.za> |
2016-02-18 00:05:17 | martin.panter | link | issue26372 messages |
2016-02-18 00:05:16 | martin.panter | create | |
|