Message260382
Crap, I just checked spams today and almost all mails of the reviewboard landed in spams ! So I made a new patch addressing all concerns:
* regex moved closer to where they're used
* regex globals start with an _
* case insensitive regex + handling(already handled in the previous revision)
* correct rounding + case suggested by Martin added as a test case
* more precise docstrings specifying that only a subset of ISO 8601 is accepted
bonus:
* useless non-capturing groups removed in regex, thus shorter and simpler
I still have a doubt though about the place I moved the regex. Tell me. |
|
Date |
User |
Action |
Args |
2016-02-17 09:15:20 | deronnax | set | recipients:
+ deronnax, barry, jcea, roysmith, belopolsky, nagle, vstinner, jwilk, mcepl, eric.araujo, Arfrever, r.david.murray, davydov, cvrebert, karlcow, Alexander.Belopolsky, perey, flying sheep, mihaic, berker.peksag, martin.panter, piotr.dobrogost, kirpit, Anders.Hovmöller, jstasiak, pbryan |
2016-02-17 09:15:19 | deronnax | set | messageid: <1455700519.49.0.358399643101.issue15873@psf.upfronthosting.co.za> |
2016-02-17 09:15:19 | deronnax | link | issue15873 messages |
2016-02-17 09:15:18 | deronnax | create | |
|