Author martin.panter
Recipients benhoyt, gvanrossum, haypo, josh.r, martin.panter, serhiy.storchaka
Date 2016-02-10.02:46:24
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1455072385.65.0.0444801076986.issue25994@psf.upfronthosting.co.za>
In-reply-to
Content
About testing that list(iterator) is empty after the iterator is closed, IMO this is an implementation detail. It would be equally (or more) sensible to raise an exception, like proposed for “async def” coroutines in Issue 25887. I suppose the main purpose of those tests is to ensure there is no leakage or warning, so maybe add some more filterwarnings() checks in those tests instead?

I left some other review comments.
History
Date User Action Args
2016-02-10 02:46:25martin.pantersetrecipients: + martin.panter, gvanrossum, haypo, benhoyt, serhiy.storchaka, josh.r
2016-02-10 02:46:25martin.pantersetmessageid: <1455072385.65.0.0444801076986.issue25994@psf.upfronthosting.co.za>
2016-02-10 02:46:25martin.panterlinkissue25994 messages
2016-02-10 02:46:24martin.pantercreate