➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author martin.panter
Recipients josh.r, martin.panter, serhiy.storchaka, squidevil
Date 2016-01-29.23:57:13
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1454111833.41.0.878498086836.issue26168@psf.upfronthosting.co.za>
In-reply-to
Content 
Left a review.

Squidevil: You say if do_mkvalue() fails, the N object is not released. But looking at the code, I think it gets stored in the tuple, and then the tuple is released: <https://hg.python.org/cpython/file/v3.5.1/Python/modsupport.c#l182>. So the only leak I can see is if the tuple construction fails.

Serhiy’s patch fixes do_mktuple(), but I think the same problem would affect do_mkdict() and do_mklist() as well.
History
Date User Action Args
2016-01-29 23:57:13martin.pantersetrecipients: + martin.panter, serhiy.storchaka, josh.r, squidevil
2016-01-29 23:57:13martin.pantersetmessageid: <1454111833.41.0.878498086836.issue26168@psf.upfronthosting.co.za>
2016-01-29 23:57:13martin.panterlinkissue26168 messages
2016-01-29 23:57:13martin.pantercreate