This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author vstinner
Recipients Mark.Shannon, brett.cannon, gvanrossum, python-dev, rhettinger, serhiy.storchaka, vstinner
Date 2016-01-18.10:53:43
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <>
Patch version 2 to take Serhiy's review in account:

* complete Objects/lnotab_notes.txt update. Replace (300, 300) delta example with (300, 200) delta for better readability (300 is the bytecode offset delta, 200 is the line number delta)
* fix added assertion in peephole: don't check the reference counter for empty byte string (which can be the empty byte string singleton)
* restore addrmap name in peephole
* don't change importlib MAGIC: we only change it between Python minor versions, it was already changed for Python 3.6a0
* assemble_lnotab() divide with positive numbers to avoid undefined behaviour on C
* use "if line_incr >= 0x80: line_incr -= 0x100" instead of struct.unpack() to convert unsigned to signed

Note: avoid also useless "if (x != NULL)" checks before calling PyMem_Free(). PyMem_Free(NULL) is well specified: do nothing.
Date User Action Args
2016-01-18 10:53:48vstinnersetrecipients: + vstinner, gvanrossum, brett.cannon, rhettinger, Mark.Shannon, python-dev, serhiy.storchaka
2016-01-18 10:53:47vstinnersetmessageid: <>
2016-01-18 10:53:47vstinnerlinkissue26107 messages
2016-01-18 10:53:47vstinnercreate