➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author martin.panter
Recipients Oren Milman, benjamin.peterson, brett.cannon, georg.brandl, martin.panter, ncoghlan, yselivanov
Date 2016-01-16.01:37:34
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1452908257.36.0.445312258276.issue26130@psf.upfronthosting.co.za>
In-reply-to
Content 
Yes it looks like this is code left over from removing the “register” keyword in revision 0530aadff696, Issue 18722. I quickly looked over the changes in that revision. I couldn’t find any more clear redundancies.

I guess this patch is also applicable to 3.5.

Maybe the following comments and copies are not needed either. But these cases look like heavily optimized code, so I would be careful with them:

https://hg.python.org/cpython/file/4b1bca0b560f/Objects/stringlib/codecs.h#l40
https://hg.python.org/cpython/file/4b1bca0b560f/Objects/stringlib/codecs.h#l519
https://hg.python.org/cpython/file/4b1bca0b560f/Objects/stringlib/find_max_char.h#l26
https://hg.python.org/cpython/file/4b1bca0b560f/Objects/unicodeobject.c#l4794
https://hg.python.org/cpython/file/4b1bca0b560f/Objects/unicodeobject.c#l4819

The last two have mangled comments /* Help allocation */, which previously read /* Help register allocation */.
History
Date User Action Args
2016-01-16 01:37:37martin.pantersetrecipients: + martin.panter, brett.cannon, georg.brandl, ncoghlan, benjamin.peterson, yselivanov, Oren Milman
2016-01-16 01:37:37martin.pantersetmessageid: <1452908257.36.0.445312258276.issue26130@psf.upfronthosting.co.za>
2016-01-16 01:37:37martin.panterlinkissue26130 messages
2016-01-16 01:37:34martin.pantercreate