This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author Oren Milman
Recipients Oren Milman
Date 2016-01-15.20:36:47
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1452890208.24.0.32779562482.issue26130@psf.upfronthosting.co.za>
In-reply-to
Content
In Parser\parser.c in classify, the 'str' parameter is assigned into the local variable 's'. However, 'str' is not used anywhere else in the function, which makes 's' redundant.

My proposal is to simply remove 's', and just use 'str' instead.

The diff is attached.

I played a little with the interpreter, and everything worked as usual.
In addition, I run 'python -m test' (on my 64-bit Windows 10) before and after applying the patch, and got the same output:
354 tests OK.
1 test altered the execution environment:
    test_subprocess
45 tests skipped:
    test_bz2 test_crypt test_curses test_dbm_gnu test_dbm_ndbm
    test_devpoll test_epoll test_fcntl test_fork1 test_gdb test_grp
    test_idle test_ioctl test_kqueue test_lzma test_nis test_openpty
    test_ossaudiodev test_pipes test_poll test_posix test_pty test_pwd
    test_readline test_resource test_smtpnet test_socketserver
    test_spwd test_sqlite test_ssl test_syslog test_tcl
    test_threadsignals test_timeout test_tix test_tk test_ttk_guionly
    test_ttk_textonly test_urllib2net test_urllibnet test_wait3
    test_wait4 test_winsound test_xmlrpc_net test_zipfile64
History
Date User Action Args
2016-01-15 20:36:48Oren Milmansetrecipients: + Oren Milman
2016-01-15 20:36:48Oren Milmansetmessageid: <1452890208.24.0.32779562482.issue26130@psf.upfronthosting.co.za>
2016-01-15 20:36:48Oren Milmanlinkissue26130 messages
2016-01-15 20:36:47Oren Milmancreate