Author abarnert
Recipients abarnert, gvanrossum, martin.panter, ncoghlan, r.david.murray, rhettinger, serhiy.storchaka
Date 2016-01-05.22:06:43
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1452031604.81.0.0594264611438.issue25958@psf.upfronthosting.co.za>
In-reply-to
Content
The second patch takes into account all the issues raised by Martin and Guido, as well as some other changes that didn't make it into the first patch because Windows hates me. And it should be flattened into a single commit, and therefore should hopefully work with Rietveld out of the box. It passes the test suite on Windows and Cygwin (and on OS X, but that's a slightly older version of the changes than what's in this flattened patch).

I think it's still an open question whether Reversible should inherit Iterable. In the current patch, as in the first, it does.

I'll go over Serhiy's Reitveld comments to see if there's anything I missed, and, if so, address it in a third attempt.

On Serhiy's test suggestions:

 * I don't think we need to repeat the same tests on every ABC. That seems more likely to introduce copy-paste bugs than to catch anything, especially since the ABCs now all share the same code, but the tests couldn't.

 * Likewise for adding repetitive tests on more __spam__, __ispam__, and __rspam__ methods.

 * However, he's definitely right that there are other kinds of fallback worth testing, like __ne__ -> __eq__. I'll review the different kinds of fallback more carefully and make sure we have tests for each case.
History
Date User Action Args
2016-01-05 22:06:46abarnertsetrecipients: + abarnert, gvanrossum, rhettinger, ncoghlan, r.david.murray, martin.panter, serhiy.storchaka
2016-01-05 22:06:44abarnertsetmessageid: <1452031604.81.0.0594264611438.issue25958@psf.upfronthosting.co.za>
2016-01-05 22:06:44abarnertlinkissue25958 messages
2016-01-05 22:06:44abarnertcreate