Author martin.panter
Recipients SilentGhost, acucci, belopolsky, berker.peksag, cvrebert, elixir, ezio.melotti, gvanrossum, jerry.elmore, lemburg, martin.panter, matrixise, r.david.murray, skip.montanaro, terry.reedy, tim.peters, vstinner
Date 2015-12-16.22:41:13
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <>
With patch v4 many tests still fail for me. How are you running the test suite? Some excerpts:

  File "/media/disk/home/proj/python/cpython/Lib/test/", line 1567, in test_isoformat
    self.assertEqual(t.isoformat(timespec='milliseconds'), "0001-02-03T04:05:01.000")
AssertionError: '0001-02-03T04:05:01.000000' != '0001-02-03T04:05:01.000'

  File "/media/disk/home/proj/python/cpython/Lib/test/", line 2310, in test_isoformat
    self.assertEqual(t.isoformat(), "00:00:00")
AssertionError: '00:00:00.000000' != '00:00:00'

  File "/media/disk/home/proj/python/cpython/Lib/test/", line 2379, in test_str
    self.assertEqual(str(self.theclass(12, 2, 3, 0)), "12:02:03")
AssertionError: '12:02:03.000000' != '12:02:03'

The C module doc string I referred to is this one; I left a review comment at the source:

>>> print(datetime.isoformat.__doc__)
[sep] -> string in ISO 8601 format, YYYY-MM-DDTHH:MM:SS[.mmmmmm][+HH:MM].

sep is used to separate the year from the time, and defaults to 'T'.
Date User Action Args
2015-12-16 22:41:13martin.pantersetrecipients: + martin.panter, lemburg, gvanrossum, tim.peters, skip.montanaro, terry.reedy, belopolsky, vstinner, ezio.melotti, r.david.murray, cvrebert, SilentGhost, berker.peksag, matrixise, elixir, jerry.elmore, acucci
2015-12-16 22:41:13martin.pantersetmessageid: <>
2015-12-16 22:41:13martin.panterlinkissue19475 messages
2015-12-16 22:41:13martin.pantercreate