Message255946
All three patches look generally good to me. I left some comments on things I would change.
FTR the tests fail to raise any exception when the redirect limit is reached because FancyURLopener.http_error_default() does not raise an error. It just returns the last result as a synthesized error page. |
|
Date |
User |
Action |
Args |
2015-12-05 12:08:34 | martin.panter | set | recipients:
+ martin.panter, orsenthil, meador.inge, bbrazil, drocco |
2015-12-05 12:08:34 | martin.panter | set | messageid: <1449317314.09.0.0842230714719.issue12923@psf.upfronthosting.co.za> |
2015-12-05 12:08:34 | martin.panter | link | issue12923 messages |
2015-12-05 12:08:33 | martin.panter | create | |
|