Message 255498 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	lemburg
Recipients	ezio.melotti, lemburg, loewis, terry.reedy, tierlieb, vstinner
Date	2015-11-27.22:28:22
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<5658D8FD.1090204@egenix.com>
In-reply-to	<1448662274.28.0.047522828432.issue25742@psf.upfronthosting.co.za>

Content
On 27.11.2015 23:11, STINNER Victor wrote: > > STINNER Victor added the comment: > > I don't see the benefit of supporting Unicode strings for setlocale() arguments: locale name are always encodable to ASCII, so loc.decode('ascii') is enough to workaround the issue. > > But well, I think it's ok if it doesn't make the code much more complex ;-) > > I wrote a patch, what do you think? Thanks :-) > Is it worth it? ;-) I think so, since the current failure for Unicode is rather obscure. BTW: Why did you use (_str, _unicode) instead of basestring ?

On 27.11.2015 23:11, STINNER Victor wrote:
> 
> STINNER Victor added the comment:
> 
> I don't see the benefit of supporting Unicode strings for setlocale() arguments: locale name are always encodable to ASCII, so loc.decode('ascii') is enough to workaround the issue.
> 
> But well, I think it's ok if it doesn't make the code much more complex ;-)
> 
> I wrote a patch, what do you think?

Thanks :-)

> Is it worth it? ;-)

I think so, since the current failure for Unicode is rather
obscure.

BTW: Why did you use (_str, _unicode) instead of basestring ?

History
Date	User	Action	Args
2015-11-27 22:28:22	lemburg	set	recipients: + lemburg, loewis, terry.reedy, vstinner, ezio.melotti, tierlieb
2015-11-27 22:28:22	lemburg	link	issue25742 messages
2015-11-27 22:28:22	lemburg	create