Message255376
Two options on portability, I think: either use splitlines() on the decoded result, or add a 'universal_newlines' keyword argument to assert_python_failure and friends that would get passed to Popen. I'd favor the latter, as other users of script_helpers may find it useful. On the other hand, that may involve a whole separate discussion, so you could use splitlines here and we could open a new issue for a script_helpers enhancement :)
Also, rather than a direct re, I'd use assertRegex. That will give a more useful error message if the test fails. |
|
Date |
User |
Action |
Args |
2015-11-25 18:19:22 | r.david.murray | set | recipients:
+ r.david.murray, vstinner, serhiy.storchaka, mystor |
2015-11-25 18:19:22 | r.david.murray | set | messageid: <1448475562.08.0.343088006639.issue25677@psf.upfronthosting.co.za> |
2015-11-25 18:19:22 | r.david.murray | link | issue25677 messages |
2015-11-25 18:19:21 | r.david.murray | create | |
|