This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author martin.panter
Recipients ArcRiley, christian.heimes, effbot, eli.bendersky, flox, martin.panter, santoso.wijaya, serhiy.storchaka
Date 2015-11-24.04:04:50
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1448337890.78.0.473910088338.issue7990@psf.upfronthosting.co.za>
In-reply-to
Content
The patch looks technically good, though I’m not a big fan of the double underscores, like element_get__text(). Maybe element_text_getter() instead, because it has to match the “getter” signature?

Personally, I would say keep the doc strings basic. If you want to add more depth about “tail”, I suggest to keep it to the main RST documentation (which was updated fairly recently). But it would be good to quickly distinguish text and tail other than by name. Maybe:

{"text", ..., "A string of text directly after the start tag, or None"},
{"tail", ..., "A string of text directly after the end tag, or None"},
History
Date User Action Args
2015-11-24 04:04:50martin.pantersetrecipients: + martin.panter, effbot, christian.heimes, eli.bendersky, ArcRiley, flox, santoso.wijaya, serhiy.storchaka
2015-11-24 04:04:50martin.pantersetmessageid: <1448337890.78.0.473910088338.issue7990@psf.upfronthosting.co.za>
2015-11-24 04:04:50martin.panterlinkissue7990 messages
2015-11-24 04:04:50martin.pantercreate