Message254662
Antoine's suggestion does not work, because "dirname" does not cover enough cases (for example trailing slash, possibly more).
As suggested by him I now use realpath (instead of abspath). I can't come up with a symlink-situation that is broken with the old code, but realpath is what "ismount" actually means.
I also added a testcase that resembles the issue, i.e. it fails with the old code and passes with the fix.
I mock the "Permission denied" by raising a generic OSError. Mocking can not resemble every real-life situation but by simulating all issues reporting and then fixing them, one should get a solid test coverage.
I also took the liberty of minor cleanup in/around the functions changed, i.e. remove unused imports and remove single-use variables to make the code easier to read.
Attached the updated patch. |
|
Date |
User |
Action |
Args |
2015-11-14 14:26:11 | Robin Roth | set | recipients:
+ Robin Roth, loewis, pitrou, rossburton, drawks, berker.peksag, pablo.sole |
2015-11-14 14:26:11 | Robin Roth | set | messageid: <1447511171.68.0.588046150002.issue2466@psf.upfronthosting.co.za> |
2015-11-14 14:26:11 | Robin Roth | link | issue2466 messages |
2015-11-14 14:26:11 | Robin Roth | create | |
|