Message254416
Yes that looks like an improvement, though I wonder what’s wrong with your original proposal (performance maybe?). In any case, it definitely needs a comment explaining the first isdir() avoids competing failures that mask EEXIST, and the exception handling avoids the race to create the directory.
A test case for the test suite would also be good. I understand it should be easy to do for Windows, just make a directory with an absolute path including a drive root like d:\. |
|
Date |
User |
Action |
Args |
2015-11-09 22:16:15 | martin.panter | set | recipients:
+ martin.panter, paul.moore, tim.golden, r.david.murray, zach.ware, steve.dower, plakhotich |
2015-11-09 22:16:15 | martin.panter | set | messageid: <1447107375.74.0.323578215247.issue25583@psf.upfronthosting.co.za> |
2015-11-09 22:16:15 | martin.panter | link | issue25583 messages |
2015-11-09 22:16:15 | martin.panter | create | |
|