This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author martin.panter
Recipients martin.panter, paul.moore, plakhotich, r.david.murray, steve.dower, tim.golden, zach.ware
Date 2015-11-09.22:16:15
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1447107375.74.0.323578215247.issue25583@psf.upfronthosting.co.za>
In-reply-to
Content
Yes that looks like an improvement, though I wonder what’s wrong with your original proposal (performance maybe?). In any case, it definitely needs a comment explaining the first isdir() avoids competing failures that mask EEXIST, and the exception handling avoids the race to create the directory.

A test case for the test suite would also be good. I understand it should be easy to do for Windows, just make a directory with an absolute path including a drive root like d:\.
History
Date User Action Args
2015-11-09 22:16:15martin.pantersetrecipients: + martin.panter, paul.moore, tim.golden, r.david.murray, zach.ware, steve.dower, plakhotich
2015-11-09 22:16:15martin.pantersetmessageid: <1447107375.74.0.323578215247.issue25583@psf.upfronthosting.co.za>
2015-11-09 22:16:15martin.panterlinkissue25583 messages
2015-11-09 22:16:15martin.pantercreate