Message254241
>>So I don’t think this is a valid bug or regression. What gave you the idea to include the colon?
"We ask that if you are going to consume the API that you pass a custom User-Agent header along with your requests. The User-Agent should primarily include information on how we can contact you, but it is also a good idea to include your application name and version."
[https://eveonline-third-party-documentation.readthedocs.org/en/latest/xmlapi/intro/#other-information]
This is why I created custom User-Agent headers:
.add_header("Contact: ","me")
.add_header("Software: ","sw")
.add_header("Version: ","0.1")
I didn't really need the colons, it just worked.
>>Does the documentation need clarifying?
In the description for "headers" in the "class urllib.request.Request" section, Mozilla's string is given as an example:
"Mozilla/5.0 (X11; U; Linux i686) Gecko/20071127 Firefox/2.0.0.11"
Including slashes, semicolons, and braces, I didn't think I would run into problems with using a colon (in the first parameter string).
>>Also, I would recommend not trying to set a “charset” attribute with the form-urlencoded content type in general. It is not standardized, and I proposed to remove the recommendation from the documentation in Issue 23360 (feedback welcome).
I agree. The examples provided should be good (standard-conform) examples.
>>I think the docs have enough big red warning boxes. But an explanation or short example might be good.
Maybe a comment line in the examples? |
|
Date |
User |
Action |
Args |
2015-11-06 23:45:29 | crickert | set | recipients:
+ crickert, r.david.murray, martin.panter |
2015-11-06 23:45:29 | crickert | set | messageid: <1446853529.59.0.778263923755.issue25570@psf.upfronthosting.co.za> |
2015-11-06 23:45:29 | crickert | link | issue25570 messages |
2015-11-06 23:45:29 | crickert | create | |
|