Author martin.panter
Recipients martin.panter, r.david.murray, sjoerdjob
Date 2015-11-03.23:39:18
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1446593959.0.0.755326424437.issue25537@psf.upfronthosting.co.za>
In-reply-to
Content
FWIW I don’t see it as a drastic change. If the current patch for Issue 12029 went ahead, I imagine the change for instance checking could look like

@@ PyErr_GivenExceptionMatches()
-    /* err might be an instance, so check its class. */
-    if (PyExceptionInstance_Check(err))
-        err = PyExceptionInstance_Class(err);
@@ given_exception_matches_inner()
-    res = PyObject_IsSubclass(err, exc);
+    if (PyExceptionInstance_Check(err)) {
+        res = PyObject_IsInstance(err, exc);
+    } else {
+        res = PyObject_IsSubclass(err, exc);
+    }
History
Date User Action Args
2015-11-03 23:39:19martin.pantersetrecipients: + martin.panter, r.david.murray, sjoerdjob
2015-11-03 23:39:19martin.pantersetmessageid: <1446593959.0.0.755326424437.issue25537@psf.upfronthosting.co.za>
2015-11-03 23:39:18martin.panterlinkissue25537 messages
2015-11-03 23:39:18martin.pantercreate