Author josh.r
Recipients Carlos Pita, Eric Price, johnmorr, josh.r, martin.panter, neologix, r.david.murray, takluyver
Date 2015-10-23.03:09:20
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1445569761.33.0.289977805962.issue23735@psf.upfronthosting.co.za>
In-reply-to
Content
Okay, sorry for repeated nitpicks, but I think you can keep the visibility of sigwinch_received as static like it was as char (to avoid having it be exported for potential use by other modules, though it won't gain any optimization benefits of static, since volatile intentionally prevents any such optimizations). static volatile sig_atomic_t is kind of a mouthful, but keeps the limited visibility you want.

Also, I still don't see a review link for the patch (which limits the ability to review in context); you might need to update your checkout and regenerate the patch so the review tool can handle it.
History
Date User Action Args
2015-10-23 03:09:21josh.rsetrecipients: + josh.r, r.david.murray, neologix, takluyver, martin.panter, Carlos Pita, johnmorr, Eric Price
2015-10-23 03:09:21josh.rsetmessageid: <1445569761.33.0.289977805962.issue23735@psf.upfronthosting.co.za>
2015-10-23 03:09:21josh.rlinkissue23735 messages
2015-10-23 03:09:20josh.rcreate