Author jneb
Recipients jneb, r.david.murray
Date 2015-10-22.07:00:35
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1445497236.14.0.00506761697272.issue24925@psf.upfronthosting.co.za>
In-reply-to
Content
I am not as good in making nice patches, but that code can be improved upon a bit as follows:
<insert patch intro blurb here, same as original>

+        if isinstance(obj, str) and source_lines is not None:
+            # This will find __test__ string doctests if and only if the string
+            # contains any unique line.
+            for offset,line in enumerate(obj.splitlines(keepends=True):
+                if source_lines.count(line)==1:
+                    lineno = source_lines.index(line)-offset
+                    break

         # We couldn't find the line number.
         return None


I thing this will improve legibility and probably also speed under most circumstances.
History
Date User Action Args
2015-10-22 07:00:36jnebsetrecipients: + jneb, r.david.murray
2015-10-22 07:00:36jnebsetmessageid: <1445497236.14.0.00506761697272.issue24925@psf.upfronthosting.co.za>
2015-10-22 07:00:36jneblinkissue24925 messages
2015-10-22 07:00:35jnebcreate