Author eric.snow
Recipients eric.snow, rhettinger, serhiy.storchaka
Date 2015-10-17.01:06:59
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1445044020.01.0.661185482172.issue25410@psf.upfronthosting.co.za>
In-reply-to
Content
Thanks for working on this, Serhiy.  I've left a review.

As to the points you outlined, I have concerns with the impact of #3 and #5 on subclasses.  Notably od.__class__ is not necessarily the same as type(od).  Also #7 may introduce an unhandled re-entrancy, causing potentially incorrect outcomes.

Also note that I was extremely careful to (almost) exactly match the pure Python implementation.  Not only did this guarantee equivalent behavior, but it simplified the porting effort.  I'm not opposed to deviating from the pure Python implementation as long as the behavior remains exactly the same.  So if you want to change the behavior of OrderedDict you must be sure to make the equivalent change in the pure Python implementation (with the associated backward-compatibility constraints).  Thanks again for working on this though.
History
Date User Action Args
2015-10-17 01:07:00eric.snowsetrecipients: + eric.snow, rhettinger, serhiy.storchaka
2015-10-17 01:07:00eric.snowsetmessageid: <1445044020.01.0.661185482172.issue25410@psf.upfronthosting.co.za>
2015-10-17 01:06:59eric.snowlinkissue25410 messages
2015-10-17 01:06:59eric.snowcreate