Author chris laws
Recipients Boris.FELD, chris laws, gvanrossum, j1o1h1n, python-dev, vstinner, yselivanov, ysionneau
Date 2015-10-06.02:30:59
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1444098660.53.0.958759611355.issue23972@psf.upfronthosting.co.za>
In-reply-to
Content
I've checked the Buildbot results and observed a few errors related to this change. Specifically the issues affect Windows and Debian.

Builder AMD64 Debian root 3.x build #2772 - http://buildbot.python.org/all/builders/AMD64%20Debian%20root%203.x/builds/2772
Builder AMD64 Windows7 SP1 3.x build #6808 - http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%203.x/builds/6808

In test_create_datagram_endpoint_sock the Windows-based buildbot raises an error related to using sock.getsockname(). This issue has been observed before on Windows using Python.

Refs:
https://mail.python.org/pipermail/python-list/2015-January/683777.html
http://stackoverflow.com/questions/15638214/socket-error-invalid-argument-supplied

In this test the socket is not really used so I was trying to get away with minimal actions to set up the test. The suggested solution would be to bind the socket before using it in the test.

sock = socket.socket(socket.AF_INET, socket.SOCK_DGRAM)
sock.bind(('0.0.0.0', 0))


In test_create_datagram_endpoint_sockopts we can't use the (else clause at line 1310) because if SO_REUSEPORT is not defined it can not be used in a check. This affects Windows and Debian where SO_REUSEPORT is not defined.

From:
if reuseport_supported:
    self.assertTrue(
        sock.getsockopt(
            socket.SOL_SOCKET, socket.SO_REUSEPORT))
else:
    self.assertFalse(
        sock.getsockopt(
            socket.SOL_SOCKET, socket.SO_REUSEPORT))

To:

if reuseport_supported:
    self.assertTrue(
        sock.getsockopt(
            socket.SOL_SOCKET, socket.SO_REUSEPORT))

I'll submit a patch to resolve these issues later today.
History
Date User Action Args
2015-10-06 02:31:00chris lawssetrecipients: + chris laws, gvanrossum, vstinner, Boris.FELD, python-dev, yselivanov, ysionneau, j1o1h1n
2015-10-06 02:31:00chris lawssetmessageid: <1444098660.53.0.958759611355.issue23972@psf.upfronthosting.co.za>
2015-10-06 02:31:00chris lawslinkissue23972 messages
2015-10-06 02:30:59chris lawscreate