Author berker.peksag
Recipients Arfrever, David.Edelsohn, Edd.Barrett, Maxime Belanger, benjamin.peterson, berker.peksag, bkabrda, dmalcolm, geoffreyspear, ischwabacher, jcea, ned.deily, pitrou, python-dev, rpointel, vajrasky, vlee, vstinner
Date 2015-09-26.16:53:56
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1443286436.73.0.750131879758.issue19884@psf.upfronthosting.co.za>
In-reply-to
Content
The version check doesn't work because 0ed1801bf4bd added #ifndef __APPLE__ to guard the code, so if you're using readline on OS X, that rl_variable_bind workaround won't work.

There are two alternatives:

1) convert ifndef to ifdef and add a check for the ``using_libedit_emulation`` variable.

    #ifdef __APPLE__
        if (using_libedit_emulation) {
            ...
    ...

looks like a common idiom in readline.c.


2) just skip the test if _READLINE_VERSION < 0x0603
History
Date User Action Args
2015-09-26 16:53:57berker.peksagsetrecipients: + berker.peksag, jcea, pitrou, vstinner, benjamin.peterson, ned.deily, Arfrever, dmalcolm, geoffreyspear, python-dev, rpointel, bkabrda, David.Edelsohn, vajrasky, Edd.Barrett, ischwabacher, vlee, Maxime Belanger
2015-09-26 16:53:56berker.peksagsetmessageid: <1443286436.73.0.750131879758.issue19884@psf.upfronthosting.co.za>
2015-09-26 16:53:56berker.peksaglinkissue19884 messages
2015-09-26 16:53:56berker.peksagcreate