Author vstinner
Recipients paul.moore, pitrou, r.david.murray, serhiy.storchaka, skrah, steve.dower, tim.golden, tim.peters, vstinner, zach.ware
Date 2015-09-18.13:48:00
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1442584081.42.0.0318488139244.issue24999@psf.upfronthosting.co.za>
In-reply-to
Content
"""

If shifting right twice (adding parens for clarity):

    (LONG_MAX >> PyLong_SHIFT) >> PyLong_SHIFT.

squashes the warnings, that would be a substantially clearer way to express the intent than the

    SIZEOF_LONG*CHAR_BIT-1 >= 2*PyLong_SHIFT

spelling.  Adding a comment *explaining* the intent would be even better.
"""

Ok, here is a patch implementing this issue: long_shift_ub.patch.

I'm unable to test it with ICC, but we can try to push it and check on the ICC buildbots.
History
Date User Action Args
2015-09-18 13:48:01vstinnersetrecipients: + vstinner, tim.peters, paul.moore, pitrou, tim.golden, r.david.murray, skrah, zach.ware, serhiy.storchaka, steve.dower
2015-09-18 13:48:01vstinnersetmessageid: <1442584081.42.0.0318488139244.issue24999@psf.upfronthosting.co.za>
2015-09-18 13:48:01vstinnerlinkissue24999 messages
2015-09-18 13:48:01vstinnercreate