This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author eryksun
Recipients David.Edelsohn, belopolsky, eryksun, larry, serhiy.storchaka, steve.dower, vstinner
Date 2015-09-08.15:25:46
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <>
Steve, it seems to me that for MSVC the EINVAL test should come first:
    olderr = errno;
    errno = 0;
    buflen = format_time(outbuf, i, fmt, &buf);
    err = errno;
    errno = olderr;
    if (buflen == 0 && err == EINVAL) {
        PyErr_SetString(PyExc_ValueError, "Invalid format string");

Then the old test could be restored, i.e. (buflen > 0 || i >= 256 * fmtlen).
Date User Action Args
2015-09-08 15:25:46eryksunsetrecipients: + eryksun, belopolsky, vstinner, larry, serhiy.storchaka, steve.dower, David.Edelsohn
2015-09-08 15:25:46eryksunsetmessageid: <>
2015-09-08 15:25:46eryksunlinkissue25029 messages
2015-09-08 15:25:46eryksuncreate