This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author steve.dower
Recipients BreamoreBoy, JohnLeitch, belopolsky, brycedarling, eryksun, georg.brandl, larry, lemburg, paul.moore, python-dev, steve.dower, tim.golden, vstinner, zach.ware
Date 2015-09-06.06:18:38
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1441520318.89.0.622683514458.issue24917@psf.upfronthosting.co.za>
In-reply-to
Content
Yeah, I came in late and in too much of a rush too :(

Backed out the broken changes, and now I'm off to bed. Not convinced there's anything that needs fixing here, and IIRC we argued through the different platform behaviours on the issue when I removed the null check that was preventing the overread.

If we do anything now, it should just be `if (outbuf[1] == '\0') break` to avoid the overread. strftime() is probably too far gone to make it consistent across platforms now.
History
Date User Action Args
2015-09-06 06:18:38steve.dowersetrecipients: + steve.dower, lemburg, georg.brandl, paul.moore, belopolsky, vstinner, larry, tim.golden, BreamoreBoy, python-dev, zach.ware, eryksun, JohnLeitch, brycedarling
2015-09-06 06:18:38steve.dowersetmessageid: <1441520318.89.0.622683514458.issue24917@psf.upfronthosting.co.za>
2015-09-06 06:18:38steve.dowerlinkissue24917 messages
2015-09-06 06:18:38steve.dowercreate