Author vstinner
Recipients aconrad, belopolsky, larry, mark.dickinson, python-dev, r.david.murray, tbarbugli, tim.peters, trcarden, vivanov, vstinner
Date 2015-09-04.15:40:27
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1441381227.84.0.349220693791.issue23517@psf.upfronthosting.co.za>
In-reply-to
Content
> Larry, I appreciate the vote of confidence, but I'm ill-equipped to help at the patch level:  (...)  The patch(es) are too broad and delicate to be sure of without kicking the tires (running contrived examples).

Well, the patches change how timedelta, .fromtimestamp() and .utcfromtimestamp() round the number of microseconds. It's a deliberate choice since it was decided that the current rounding mode is a bug, and not a feature :-)

The code is well tested. There are unit tests on how numbers are rounded for: timedelta, .(utc)fromtimestamp(), and even the C private API _PyTime. The code is (almost) the same in default and was validated on various platforms. So I'm confident on the change.
History
Date User Action Args
2015-09-04 15:40:27vstinnersetrecipients: + vstinner, tim.peters, mark.dickinson, belopolsky, larry, r.david.murray, aconrad, vivanov, python-dev, tbarbugli, trcarden
2015-09-04 15:40:27vstinnersetmessageid: <1441381227.84.0.349220693791.issue23517@psf.upfronthosting.co.za>
2015-09-04 15:40:27vstinnerlinkissue23517 messages
2015-09-04 15:40:27vstinnercreate