Author martin.panter
Recipients Garfield222, Lukasa, Pierre.Tardy, adambrenecki, berker.peksag, christian.heimes, demian.brecht, icordasc, jitterman, lonetwin, martin.panter, orsenthil, pitrou, r.david.murray, raymondr, serhiy.storchaka, stamparm
Date 2015-09-03.04:40:22
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1441255222.9.0.491016944884.issue17849@psf.upfronthosting.co.za>
In-reply-to
Content
I still don’t think the test case is a reasonable example. According to <http://www.w3.org/Protocols/HTTP/AsImplemented.html>, HTTP 0.9 only supported GET, not CONNECT, and doesn’t include any header fields in the protocol (such as your X-Foo: bar). It would make more sense to me to adjust the check at <https://hg.python.org/cpython/file/69ea73015132/Lib/httplib.py#l813> to also check for version == "HTTP/0.9". That would probably eliminate the need to mess too much with the details of the LineAndFileWrapper class.

But if you wanted to parse the CONNECT response as a HTTP 0.9 response, I think you should not try to parse any header, because that will tend to skip over the start of the actual response.

Also, I assume the change to “configure” is unrelated.
History
Date User Action Args
2015-09-03 04:40:22martin.pantersetrecipients: + martin.panter, orsenthil, pitrou, christian.heimes, r.david.murray, berker.peksag, serhiy.storchaka, stamparm, icordasc, demian.brecht, adambrenecki, raymondr, Lukasa, lonetwin, Pierre.Tardy, jitterman, Garfield222
2015-09-03 04:40:22martin.pantersetmessageid: <1441255222.9.0.491016944884.issue17849@psf.upfronthosting.co.za>
2015-09-03 04:40:22martin.panterlinkissue17849 messages
2015-09-03 04:40:22martin.pantercreate