Author petr.viktorin
Recipients docs@python, larry, ncoghlan, petr.viktorin
Date 2015-08-25.16:41:32
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1440520892.99.0.130273606833.issue24937@psf.upfronthosting.co.za>
In-reply-to
Content
In https://docs.python.org/3/howto/cporting.html#cobject-replaced-with-capsule (added in issue13053):

1) __PyCapsule_GetField is defined as::

    #define __PyCapsule_GetField(capsule, field, default_value) ...

but called as::

    __PyCapsule_GetField(capsule, field)


2) __PyCapsule_SetField returns the wrong value (1 for success, 0 for failure).

3) Both the getter and setter don't set the exception on failure, leading to "SystemError: error return without exception set".

Here's a patch.
History
Date User Action Args
2015-08-25 16:41:33petr.viktorinsetrecipients: + petr.viktorin, ncoghlan, larry, docs@python
2015-08-25 16:41:32petr.viktorinsetmessageid: <1440520892.99.0.130273606833.issue24937@psf.upfronthosting.co.za>
2015-08-25 16:41:32petr.viktorinlinkissue24937 messages
2015-08-25 16:41:32petr.viktorincreate