This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author r.david.murray
Recipients BreamoreBoy, barry, brett.cannon, christopher.hogan, dstufft, eric.araujo, mgiuca, ncoghlan, r.david.murray, steve.dower, tarek, zach.ware
Date 2015-08-20.14:02:08
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1440079329.36.0.890065945892.issue8987@psf.upfronthosting.co.za>
In-reply-to
Content
*I'm* not suggesting using Popen.  That would be a more significant change to the code, and I don't see a motivation for it.  I'm just suggesting using list2cmdline for the quoting.  (If we were rewriting distutils it would be a different story, but we're not.)

And no, Popen with shell=True does *not* handle quoting.  If you use shell=True, *you* are responsible for doing correct quoting (and is what makes using shell=True so dangerous).  That applies to both unix and windows, and the confusion about that fact was what led to the need for the "fix" backout in issue 8972.

If a fix can't go in as a bug fix (whether or not it gets into 3.5.0), then we should perhaps instead consider the rewrite for 3.6: provide a *new* distutils function that does use Popen and does things "right" (based on everything we've learned since distutils was written), leaving the old function in place, deprecated, for backward compatibility.

That doesn't solve the problem for people running in to this bug trying to build extensions for 2.7, 3.4, and 3.5, though.
History
Date User Action Args
2015-08-20 14:02:09r.david.murraysetrecipients: + r.david.murray, barry, brett.cannon, ncoghlan, tarek, eric.araujo, mgiuca, BreamoreBoy, zach.ware, steve.dower, dstufft, christopher.hogan
2015-08-20 14:02:09r.david.murraysetmessageid: <1440079329.36.0.890065945892.issue8987@psf.upfronthosting.co.za>
2015-08-20 14:02:09r.david.murraylinkissue8987 messages
2015-08-20 14:02:08r.david.murraycreate