Author Unit03
Recipients Unit03, berker.peksag, martin.panter, maurosr, milap.py, python-dev, r.david.murray, serhiy.storchaka, taddeimania
Date 2015-07-21.13:09:27
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1437484168.02.0.362277582052.issue23883@psf.upfronthosting.co.za>
In-reply-to
Content
I'm getting patches ready with amendments you've proposed. Two things, though (and two on Rietveld):

> That raiseExecptions thing looks like a typo to me. The code should probably be monkey patching the module variable, and restoring it after the test. Then you wouldn’t need to add your extra typoed version to the blacklist.

Wouldn't it be better to just blacklist the typoed version in this patch, with proper comment, and then fix the typo along with test? Working it around like you proposed looks like unnecessary overkill. I'm also not yet sure where is the "don't change too much in one patch" border.

> pickletools.OpcodeInfo: It is briefly mentioned as the type of the first item of genops(). I don’t have a strong opinion, but I tended to agree with your previous patch which added it to __all__.

That addition was a little absentminded of me, sorry for that. Is such brief mention considered a documentation for a part of API in this case?
History
Date User Action Args
2015-07-21 13:09:28Unit03setrecipients: + Unit03, r.david.murray, python-dev, berker.peksag, martin.panter, serhiy.storchaka, milap.py, maurosr, taddeimania
2015-07-21 13:09:28Unit03setmessageid: <1437484168.02.0.362277582052.issue23883@psf.upfronthosting.co.za>
2015-07-21 13:09:28Unit03linkissue23883 messages
2015-07-21 13:09:27Unit03create