Message245813
I did some regression testing and reviewed the code; LGTM.
As for the code structure issues, I agree that the duplication is undesirable (the readability argument is not that convincing), but Serhiy's patch is consistent with the existing design. As such, I think the structure issue is a separate one and definitely should not hold this patch up. |
|
Date |
User |
Action |
Args |
2015-06-25 15:36:18 | meador.inge | set | recipients:
+ meador.inge, rhettinger, ncoghlan, larry, serhiy.storchaka, yselivanov |
2015-06-25 15:36:18 | meador.inge | set | messageid: <1435246578.91.0.674488559113.issue24483@psf.upfronthosting.co.za> |
2015-06-25 15:36:18 | meador.inge | link | issue24483 messages |
2015-06-25 15:36:18 | meador.inge | create | |
|