Author martin.panter
Recipients Unit03, berker.peksag, martin.panter, maurosr, milap.py, python-dev, r.david.murray, serhiy.storchaka, taddeimania
Date 2015-06-22.02:33:50
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1434940431.09.0.370588487972.issue23883@psf.upfronthosting.co.za>
In-reply-to
Content
To avoid the list of patches here getting out of control, I suggest opening a fresh issue for any new patches that aren’t a new version of the patches here. We can mark the new issue as a dependency of this one to keep track of it.

Nice work with the check__all__() function. I left some comments on Reitveld. Also, it currently ignores items satisfying either of these checks:

* isinstance(module_object, types.ModuleType)
* getattr(module_object, '__module__', None) not in name_of_module

The first is largely redundant with the second, because module objects don’t have a __module__ attribute. However I wonder if it would be better to drop the second check and just rely on the ModuleType check, making the test stricter. Or would this be too annoying in some cases (requiring a huge blacklist)? If so, maybe make the name_of_module checking optional.

===

Serhiy: ftplib.Error does not actually appear to be documented. Perhaps it should not be added to __all__ after all? (excuse the pun)
History
Date User Action Args
2015-06-22 02:33:51martin.pantersetrecipients: + martin.panter, r.david.murray, python-dev, berker.peksag, serhiy.storchaka, milap.py, maurosr, taddeimania, Unit03
2015-06-22 02:33:51martin.pantersetmessageid: <1434940431.09.0.370588487972.issue23883@psf.upfronthosting.co.za>
2015-06-22 02:33:51martin.panterlinkissue23883 messages
2015-06-22 02:33:50martin.pantercreate