Author jaraco
Recipients Arfrever, gumblex, jaraco, terry.reedy
Date 2015-06-20.15:14:02
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1434813242.52.0.789223543845.issue20387@psf.upfronthosting.co.za>
In-reply-to
Content
@gumblex: This is a good start. It certainly provides a candidate implementation.

First, can I suggest that you remove the changes pertinent to the "at least two elements" and address that in a separate ticket/discussion?

Second, any patch will necessarily need to include a test that fails before the patch and passes after the test.

Third, and least important, the proposed implementation adds a lot of branching and cognitive complexity to an already complicated function. I'd like to work on the implementation to see if we can make it easier to comprehend. That said, practicality beats purity, so if it passes the test, then it's surely acceptable.
History
Date User Action Args
2015-06-20 15:14:02jaracosetrecipients: + jaraco, terry.reedy, Arfrever, gumblex
2015-06-20 15:14:02jaracosetmessageid: <1434813242.52.0.789223543845.issue20387@psf.upfronthosting.co.za>
2015-06-20 15:14:02jaracolinkissue20387 messages
2015-06-20 15:14:02jaracocreate