➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author ronaldoussoren
Recipients ned.deily, ronaldoussoren, vajrasky
Date 2015-06-17.15:10:47
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1434553847.48.0.948662496257.issue24380@psf.upfronthosting.co.za>
In-reply-to
Content 
The patch is not correct. 

You're probably building with a new enough version of OSX as the deployment target. _scproxy.c should recognise this and should only perform the != NULL test when the variable address might be NULL.

#if MAC_OS_X_VERSION_MIN_REQUIRED < MAC_OS_X_VERSION_10_4
   if (if (&kSCPropNetProxiesExcludeSimpleHostnames != NULL) {
#end
      ....

#if MAC_OS_X_VERSION_MIN_REQUIRED <= MAC_OS_X_VERSION_10_4
   } else {
       ...
   }
#endif

And as the variable is available on OSX 10.4 we could just drop the test and assume it is available.
History
Date User Action Args
2015-06-17 15:10:47ronaldoussorensetrecipients: + ronaldoussoren, ned.deily, vajrasky
2015-06-17 15:10:47ronaldoussorensetmessageid: <1434553847.48.0.948662496257.issue24380@psf.upfronthosting.co.za>
2015-06-17 15:10:47ronaldoussorenlinkissue24380 messages
2015-06-17 15:10:47ronaldoussorencreate