Author eric.snow
Recipients christian.heimes, eric.snow
Date 2015-06-01.16:24:34
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1433175874.7.0.776296707125.issue24349@psf.upfronthosting.co.za>
In-reply-to
Content
(from msg244587 in issue16991)

Coverity has found an issue in odict, too:

*** CID 1302699:  Null pointer dereferences  (NULL_RETURNS)
/Objects/odictobject.c: 1316 in odict_copy()
1310             od_copy = PyObject_CallFunctionObjArgs((PyObject *)Py_TYPE(od), NULL);
1311         if (od_copy == NULL)
1312             return NULL;
1313     
1314         if (PyODict_CheckExact(od)) {
1315             _odict_FOREACH(od, node) {
>>>     CID 1302699:  Null pointer dereferences  (NULL_RETURNS)
>>>     Dereferencing a pointer that might be null "PyDict_GetItem((PyObject *)(PyObject *)od, node->key)" when calling "PyODict_SetItem".
1316                 int res = PyODict_SetItem((PyObject *)od_copy,
1317                                           _odictnode_KEY(node),
1318                                           _odictnode_VALUE(node, od));
1319                 if (res != 0)
1320                     goto fail;
1321             }
History
Date User Action Args
2015-06-01 16:24:34eric.snowsetrecipients: + eric.snow, christian.heimes
2015-06-01 16:24:34eric.snowsetmessageid: <1433175874.7.0.776296707125.issue24349@psf.upfronthosting.co.za>
2015-06-01 16:24:34eric.snowlinkissue24349 messages
2015-06-01 16:24:34eric.snowcreate