➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author grajagandev
Recipients grajagandev
Date 2015-05-29.17:20:05
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1432920005.51.0.0928225945144.issue24326@psf.upfronthosting.co.za>
In-reply-to
Content 
Hi - 

During a code review of Modules/audioop.c I noted that weightB is never divided by the GCD while weightA is divided twice. This is contrary to the comment and appears to be a bug:

    /* divide weightA and weightB by their greatest common divisor */
    d = gcd(weightA, weightB);
    weightA /= d;
    weightA /= d;

The patch file below (hg diff) fixes this issue.
History
Date User Action Args
2015-05-29 17:20:05grajagandevsetrecipients: + grajagandev
2015-05-29 17:20:05grajagandevsetmessageid: <1432920005.51.0.0928225945144.issue24326@psf.upfronthosting.co.za>
2015-05-29 17:20:05grajagandevlinkissue24326 messages
2015-05-29 17:20:05grajagandevcreate